feat: add url config validation #5578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b feature/add-config-url-validation https://github.com/XuXianTao/hexo.git
cd hexo
npm install
npm test |
2 tasks
SukkaW
reviewed
Nov 30, 2024
| @@ -12,6 +12,8 @@ export = (ctx: Hexo): void => { | |||
| try { | |||
| // eslint-disable-next-line no-new | |||
| new URL(config.url); | |||
| // eslint-disable-next-line no-new | |||
| new URL('source/_post/xxx', config.url); | |||
There was a problem hiding this comment.
Maybe change source/_post/xxx to config.root, config.permalink, or something similar?
There was a problem hiding this comment.
It's a good idea, but I think it will fail because of wrong config.root or config.permalink, not like the error description Invalid config detected: "url" should be a valid URL!.
I think config.root, config.permalink should be check in other part. And the config.root is already checked after this.
So, I think a simple string variable may be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add
urlconfig validation.To resolve the issue. #5577
Screenshots
Pull request tasks